Skip to content

fix(ci): fix iOS harness action version and app path#519

Merged
patrickkabwe merged 2 commits into
patrickkabwe:mainfrom
eumaninho54:fix/harness-ios-workflow
Jul 9, 2026
Merged

fix(ci): fix iOS harness action version and app path#519
patrickkabwe merged 2 commits into
patrickkabwe:mainfrom
eumaninho54:fix/harness-ios-workflow

Conversation

@eumaninho54

@eumaninho54 eumaninho54 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The generated `harness-ios.yml` has two bugs that break iOS CI on every new module:

Bug 1 — wrong harness action version
Uses `callstackincubator/react-native-harness@v1.0.0` which has no `action.yml` and fails immediately. The Android workflow already uses `v1.2.0`.

Bug 2 — wrong `app:` path
The `app:` path includes the `example/` prefix, but since `projectRoot: example` is set, paths are already resolved relative to `example/`. This produces a doubled prefix (`example/example/ios/...`) and the app bundle is never found. The Android workflow already uses the correct convention (`android/app/build/...` relative to `projectRoot`).

Fix

  • Bump iOS harness action to `v1.2.0` (same as Android)
  • Change `app:` from `example/ios/build/...` to `ios/build/...`

Both changes are in `src/code-snippets/code.js.ts`, inside `getHarnessJobCode()`.

Tested on

Verified by running the fixed workflow on a generated module, iOS harness now boots the simulator and runs tests successfully.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the iOS build workflow to use a newer supported setup, improving compatibility and reducing build issues.
    • Corrected the app path used by the workflow so iOS jobs point to the right project location.

- Bump harness action from v1.0.0 to v1.2.0 (v1.0.0 has no action.yml)
- Fix app path: remove example/ prefix since projectRoot=example already
  resolves paths relative to the example directory (same convention as Android)
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@eumaninho54, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 515503c3-4b7a-497e-b7af-d1cd6389a09a

📥 Commits

Reviewing files that changed from the base of the PR and between a9417e4 and a84b192.

📒 Files selected for processing (1)
  • e2e/harness-workflows.test.ts
📝 Walkthrough

Walkthrough

Updated the generated iOS GitHub Actions workflow template to reference callstackincubator/react-native-harness@v1.2.0 instead of v1.0.0, and changed the app artifact path from example/ios/... to ios/....

Changes

iOS Harness Workflow Update

Layer / File(s) Summary
Update harness action version and app path
src/code-snippets/code.js.ts
Bumps the react-native-harness action to v1.2.0 and updates the with.app path to remove the leading example/ directory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating the iOS harness action version and fixing the app path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/code-snippets/code.js.ts`:
- Around line 448-450: The iOS harness version changed in the generated
workflow, but the e2e assertion still expects the old value. Update the
expectation in the harness workflow test (the `e2e/harness-workflows.test.ts`
check for the iOS `uses:` entry) to match
`callstackincubator/react-native-harness@v1.2.0`, keeping it aligned with the
code generated by the snippet in `code.js.ts`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69ef3a95-bb0f-4457-a235-5932c2b6ee78

📥 Commits

Reviewing files that changed from the base of the PR and between 54e661c and a9417e4.

📒 Files selected for processing (1)
  • src/code-snippets/code.js.ts

Comment thread src/code-snippets/code.js.ts
@patrickkabwe

Copy link
Copy Markdown
Owner

Hi thanks for resolving this issue. however i noticed ci is red please take a look.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@eumaninho54

Copy link
Copy Markdown
Contributor Author

Fixed. The e2e test still expected v1.0.0 for the ios harness action... i updated the assertion to match v1.2.0. Does this look good to you?

@patrickkabwe patrickkabwe merged commit addba1c into patrickkabwe:main Jul 9, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants