fix(ci): fix iOS harness action version and app path#519
Conversation
- Bump harness action from v1.0.0 to v1.2.0 (v1.0.0 has no action.yml) - Fix app path: remove example/ prefix since projectRoot=example already resolves paths relative to the example directory (same convention as Android)
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the generated iOS GitHub Actions workflow template to reference ChangesiOS Harness Workflow Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/code-snippets/code.js.ts`:
- Around line 448-450: The iOS harness version changed in the generated
workflow, but the e2e assertion still expects the old value. Update the
expectation in the harness workflow test (the `e2e/harness-workflows.test.ts`
check for the iOS `uses:` entry) to match
`callstackincubator/react-native-harness@v1.2.0`, keeping it aligned with the
code generated by the snippet in `code.js.ts`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 69ef3a95-bb0f-4457-a235-5932c2b6ee78
📒 Files selected for processing (1)
src/code-snippets/code.js.ts
|
Hi thanks for resolving this issue. however i noticed ci is red please take a look. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Fixed. The e2e test still expected |
The generated `harness-ios.yml` has two bugs that break iOS CI on every new module:
Bug 1 — wrong harness action version
Uses `callstackincubator/react-native-harness@v1.0.0` which has no `action.yml` and fails immediately. The Android workflow already uses `v1.2.0`.
Bug 2 — wrong `app:` path
The `app:` path includes the `example/` prefix, but since `projectRoot: example` is set, paths are already resolved relative to `example/`. This produces a doubled prefix (`example/example/ios/...`) and the app bundle is never found. The Android workflow already uses the correct convention (`android/app/build/...` relative to `projectRoot`).
Fix
Both changes are in `src/code-snippets/code.js.ts`, inside `getHarnessJobCode()`.
Tested on
Verified by running the fixed workflow on a generated module, iOS harness now boots the simulator and runs tests successfully.
Summary by CodeRabbit