Add MIME type mappings for mobile app package formats#241
Merged
patrickdappollonio merged 5 commits intomasterfrom Mar 23, 2026
Merged
Add MIME type mappings for mobile app package formats#241patrickdappollonio merged 5 commits intomasterfrom
patrickdappollonio merged 5 commits intomasterfrom
Conversation
The nolint annotations on individual lines handle these false positives instead of blanket-excluding the rules project-wide.
The os.Open calls in serveFile and renderMarkdownFile operate on paths derived from the serving root, not raw user input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.apk,.xapk,.aab, and.ipafilesContent-Typeheader would be detected asapplication/zip(since APKs are ZIP archives internally), causing some Android devices (Onn, Android phones, Android TV) to append.zipto the downloaded filename, making the APK uninstallableTest plan
go test ./internal/ctype/...to verify no regressions.apkfile and confirm the responseContent-Typeisapplication/vnd.android.package-archive.zipextension is appended