Skip to content

Remove redundant data models and add DaVinci Forms support#501

Merged
patrickcping merged 9 commits intomainfrom
feature/davinci-forms-qr-code-alignment/pc/20260130
Mar 31, 2026
Merged

Remove redundant data models and add DaVinci Forms support#501
patrickcping merged 9 commits intomainfrom
feature/davinci-forms-qr-code-alignment/pc/20260130

Conversation

@patrickcping
Copy link
Copy Markdown
Owner

Description

This PR updates the management module to align with the latest DaVinci Forms API contract and adds support for new form field types.

Changes

  • Note Remove redundant data models
  • Enhancement Re-aligned the FormFieldQrCode model to the API contract for DaVinci Forms
  • Enhancement Added support for FormFieldPolling, FormFieldFIDO2, FormFieldSingleCheckbox and FormFieldAgreement data models for DaVinci Forms

Technical Details

Models Removed

  • EnumAdministratorSecurityAllowedMethods
  • EnumNotificationsSettingsEmailDeliverySettingsCustomProtocol
  • EnumFormQrCodeType

Models Added

  • FormFieldPolling / FormPolling
  • FormFieldFIDO2 / FormFIDO2
  • FormFieldSingleCheckbox / FormSingleCheckbox
  • FormFieldFormAgreement / FormAgreement

Models Updated

  • FormFieldQrCode - Re-aligned to API contract (removed key and qrCodeType, added size and fallbackText)
  • All FormField* models - Added optional visibility property
  • EnumFormFieldType - Added new field types: POLLING, FIDO2, SINGLE_CHECKBOX, AGREEMENT

Test Evidence

Code was generated via make generate in the management module:

make generate

The generation completed successfully with exit code 0.

- Remove redundant data models

- Re-align FormFieldQrCode model to API contract for DaVinci Forms

- Add support for FormFieldPolling, FormFieldFIDO2, FormFieldSingleCheckbox and FormFieldAgreement data models for DaVinci Forms
@henryrecker-pingidentity
Copy link
Copy Markdown
Collaborator

henryrecker-pingidentity commented Feb 11, 2026

@patrickcping These changes are missing some fields:

@patrickcping
Copy link
Copy Markdown
Owner Author

DOCS-11070 raised to clarify the findings

@patrickcping patrickcping merged commit 430cd61 into main Mar 31, 2026
15 checks passed
@patrickcping patrickcping deleted the feature/davinci-forms-qr-code-alignment/pc/20260130 branch March 31, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants