feat: add -q/--query and -l/--limit flags to list-collectors#17
Merged
Conversation
The collectors API returns all collectors with no server-side filtering. Add client-side filtering by name or category (case-insensitive substring match) and an optional limit, consistent with the list-monitors interface. Closes #11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-q/--queryflag to filter collectors by name or category (case-insensitive substring match)-l/--limitflag to cap the number of returned collectorslist-monitorsinterfaceDetails
The Sumo Logic
/collectorsAPI doesn't support server-side filtering, so filtering is applied client-side after fetching all collectors. The query matches against bothnameandcategoryfields. Limit is applied after filtering.Files changed:
lib/sumologic/cli.rb— Thor option declarations and updated help textlib/sumologic/cli/commands/list_collectors_command.rb— Pass query/limit to clientlib/sumologic/metadata/collector.rb— Client-side filter and limit logiclib/sumologic/client.rb— Updated facade signaturespec/sumologic/metadata/collector_spec.rb— New: 8 tests for filtering/limitingspec/sumologic/cli/commands/commands_spec.rb— Updated command testTest plan
Closes #11