Remove /estimates/ecommerce endpoint calls#79
Merged
Conversation
Contributor
|
@holtbp did you generate from client-code-generation. This (the failing test on the SDK) is very very not urgent, so feel free to leave this be for now. |
Contributor
Author
Yes, generated and it seems maybe my pre-commit hook did some formatting here via |
pcothenet
approved these changes
Apr 9, 2025
pcothenet
reviewed
Apr 29, 2025
Comment on lines
+15
to
+16
| with: | ||
| version: "24.10.0" |
Contributor
There was a problem hiding this comment.
We were getting some issues due to inconsistent versions of black.
pcothenet
reviewed
Apr 29, 2025
Comment on lines
-29
to
-32
| - name: Setup Python | ||
| uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2.3.4 | ||
| with: | ||
| python-version: '3.6' |
Contributor
There was a problem hiding this comment.
We do not need this since make test run the tests in Docker. This prevents version inconsistencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove calls to
/estimates/ecommerceendpoint that does not exist.Why
Endpoint was removed.
SDK Release Checklist