Fix cumulative value calculation for recursive functions in Table view #6128
+29
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the Table view, recursive functions (functions that appear multiple times in the same call stack) may display Cumulative (%) values greater than 100%. For example (tested with parca 0.25.0):
Root Cause
When building the table, the code iterates through each frame in a stacktrace and adds the sample value to that function's cumulative. When a function appears multiple times in the same stacktrace (due to recursion), its cumulative value gets counted multiple times.
Example:
Solution
Track which table rows have been counted for each sample using a
seenInSamplemap. Only add to cumulative for the first occurrence of a function in each sample, while still maintaining caller/callee relationships for all occurrences.