Add an initializer for static binaries to use#653
Open
indirect wants to merge 1 commit into
Open
Conversation
Signed-off-by: André Arko <andre@arko.net>
199aa31 to
77f4fe5
Compare
Collaborator
|
I mean it is not bad as first draft. One thing to think of would to be to make the Another thing I wonder about is if it would be interesting in the bundled feature to have the option to link everything statically. |
Author
|
I would love to have a feature that makes everything static! That would straight up solve my use-case entirely. I will give this another pass soon to see if I can shrink the unsafes and get all the tests passing again now that I have rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project that uses this crate, but that would ideally be built completely statically for reproducibility reasons. With a fully static binary,
dlopenis an empty stub, which prevented this crate from working.I'm extremely unsure if this is the best approach for the crate as a whole, but I can confirm this change does in fact solve my specific problem, making it possible to use the rest of the crate even when
dlopenisn't available.You can see it in practice (and try out using this code) over at https://github.com/lunal-dev/kettle.