feat(esapi): add missing TPM commands in authenticated_countdown_timer#652
Open
hyperfinitism wants to merge 1 commit into
Open
feat(esapi): add missing TPM commands in authenticated_countdown_timer#652hyperfinitism wants to merge 1 commit into
hyperfinitism wants to merge 1 commit into
Conversation
Added the following wrapper function with integration test: - act_set_timeout (ESAPI spec 11.3.116) swtpm (libtpms) does not support TPM2_ACT_SetTimeout; this command returns TPM_RC_COMMAND_CODE. The integration test is marked #[ignore], and the doc examples is marked no_run. Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
Superhepper
reviewed
Jun 4, 2026
| /// .expect("Call to act_set_timeout failed"); | ||
| /// }); | ||
| /// ``` | ||
| pub fn act_set_timeout(&mut self, act_handle: ObjectHandle, start_timeout: u32) -> Result<()> { |
Collaborator
There was a problem hiding this comment.
I am not so sure about this handle. I was working on something that had similar problems but for attached components. That creates a specific handle type that only allows for a handle in a specific range. I think something similar would be appropriate here as well or depending on the situation maybe it would be better to do something similar to what have been done for PCR handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the following wrapper function with integration test:
act_set_timeout(ESAPI spec 11.3.116)This was extracted from #625.
Limitation
swtpmdoes not support TPM2_ACT_SetTimeout; this command returnsTPM_RC_COMMAND_CODE. The integration test is marked#[ignore], and the doc examples is markedno_run.