ek: fixup auth policies#594
Closed
baloo wants to merge 2 commits into
Closed
Conversation
For a reason I'm not clear about, the templates used for the EK were incorrect for anything but NistP256 and Rsa2048. I'm fairly convinced the authPolicy should always be the values of PolicyA (Table 15 in the [spec]). [spec]: https://trustedcomputinggroup.org/wp-content/uploads/EK-Credential-Profile-For-TPM-Family-2.0-Level-0-V2.5-R1.0_28March2022.pdf#page=55 Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>
baloo
force-pushed
the
baloo/ek/fixup-auth-policies
branch
from
5d3fa95 to
bfce000
Compare
Contributor
Author
|
This showed up in the tests I've wrote for #585 I'm still not sure I'm reading this correctly, this code seems to be intentional. Please use a mountain of salt when reviewing that PR. |
Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>
baloo
force-pushed
the
baloo/ek/fixup-auth-policies
branch
from
897217e to
db7f6cf
Compare
Contributor
Author
Contributor
|
No only the EK low range templates use PolicyA, the high range ones use PolicyB. Note that PolicyB = (PolicyA || PolicyC) |
Contributor
Author
|
brrr, I hate TPMs. Thank you! I completely missed that. That explains why the policysecret to use an EK that was neither of rsa2048 or nist p256 was not enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a reason I'm not clear about, the templates used for the EK were incorrect for anything but NistP256 and Rsa2048.
I'm fairly convinced the authPolicy should always be the values of PolicyA (Table 15 in the spec).