Skip to content

feat(message-document): Add origami loading indicator#590

Merged
marhkb merged 2 commits into
mainfrom
marhkb/feat/message-document/loading-indicator
Oct 1, 2023
Merged

feat(message-document): Add origami loading indicator#590
marhkb merged 2 commits into
mainfrom
marhkb/feat/message-document/loading-indicator

Conversation

@marhkb
Copy link
Copy Markdown
Collaborator

@marhkb marhkb commented Sep 30, 2023

Copied from #496

@marhkb marhkb mentioned this pull request Sep 30, 2023
@marhkb marhkb requested a review from yuraiz September 30, 2023 20:08
@marhkb marhkb force-pushed the marhkb/feat/message-document/loading-indicator branch from 2f73c2e to d5a2565 Compare September 30, 2023 20:16
@yuraiz
Copy link
Copy Markdown
Contributor

yuraiz commented Sep 30, 2023

Currently the mask isn't applies to the loading indicator

telegram-cloud-photo-size-2-5244719908611281407-y

telegram-cloud-photo-size-2-5244719908611281409-m

I think the loading indicator can be put inside StatusIndicator
and progress and visibility logic will be handled in StatusIndicator::set_status

Then it'l' be masked and work nicely with things like #566

@marhkb marhkb force-pushed the marhkb/feat/message-document/loading-indicator branch from d5a2565 to 00e4fbc Compare October 1, 2023 08:33
Comment thread data/resources/style.css Outdated
Co-authored-by: yuraiz <yuraiz@users.noreply.github.com>
@marhkb marhkb force-pushed the marhkb/feat/message-document/loading-indicator branch from 00e4fbc to a7756b6 Compare October 1, 2023 08:54
@marhkb marhkb merged commit 7c78bf6 into main Oct 1, 2023
@marhkb marhkb deleted the marhkb/feat/message-document/loading-indicator branch October 1, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants