[DNM] hack: add Do-Not-Retry hint when retries are exhausted#2820
Draft
bjlaub wants to merge 8 commits into
Draft
[DNM] hack: add Do-Not-Retry hint when retries are exhausted#2820bjlaub wants to merge 8 commits into
bjlaub wants to merge 8 commits into
Conversation
Generate changelog in
|
bjlaub
commented
Dec 17, 2025
| import com.palantir.dialogue.futures.DialogueFutures; | ||
| import java.util.Optional; | ||
|
|
||
| // a channel that detects if upstream dialogue retries were exhausted, and fails fast if so |
Contributor
Author
There was a problem hiding this comment.
oops, this comment is wrong - don't fail fast here, instead set a response attachment that causes RetryingChannel to short-circuit
bjlaub
commented
Dec 17, 2025
|
|
||
| private static final String DIALOGUE_RETRIES_EXHAUSTED_HEADER = "Dialogue-Retries-Exhausted"; | ||
|
|
||
| public static boolean isRetriesExhausted(Response response) { |
Contributor
Author
There was a problem hiding this comment.
we should separate the response attachment logic from the header parsing logic into two separate classes, the former being package-private
added 2 commits
December 18, 2025 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?