Skip to content

feat: [IOCOM-3240] addition of FSE banner #8252

Merged
forrest57 merged 4 commits into
masterfrom
IOCOM-3240-app-implementazione-banner-fse-nella-sezione-messaggi
Jul 8, 2026
Merged

feat: [IOCOM-3240] addition of FSE banner #8252
forrest57 merged 4 commits into
masterfrom
IOCOM-3240-app-implementazione-banner-fse-nella-sezione-messaggi

Conversation

@forrest57

Copy link
Copy Markdown
Contributor

Short description

This PR includes the FSE banner in the landing screen along with its required logic

List of changes proposed in this pull request

  • component
  • reducer for closure persistance
  • io-services-metadata based selectors for dismissability and remote URL
  • updated io-services-metadata tag version
  • related tests

How to test

automated tests should pass. also, using the dev-server, check out this PR's branch and verify that:

  • removing the banner's ID from the devserver's renderability array correctly hides the banner in app
  • updating the is_dismissable field correctly shows and hides the "x" button used to dismiss the banner
  • once the banner is dismissed, the user choice is persisted and does not rerender on new sessions
  • logging in with a different user and/or clearing the app's cache correctly resets this check, thus showing the banner again

@forrest57 forrest57 self-assigned this Jul 7, 2026
@forrest57 forrest57 requested a review from ChrisMattew as a code owner July 7, 2026 15:42
@forrest57 forrest57 added the IO-FIP IO Foundation - Interazioni & Preferenze label Jul 7, 2026
@forrest57 forrest57 requested review from a team, emilio-dimari, gispada and soixdev91 as code owners July 7, 2026 15:42
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.81%. Comparing base (9c5c789) to head (3a64d71).

Files with missing lines Patch % Lines
...rvices/fseDiscoveryBanner/store/selectors/index.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8252      +/-   ##
==========================================
+ Coverage   62.77%   62.81%   +0.04%     
==========================================
  Files        1952     1956       +4     
  Lines       37078    37117      +39     
  Branches     6201     6210       +9     
==========================================
+ Hits        23275    23315      +40     
+ Misses      12418    12416       -2     
- Partials     1385     1386       +1     
Files with missing lines Coverage Δ
...ScreenMultiBanner/utils/landingScreenBannerMap.tsx 100.00% <100.00%> (ø)
...s/features/services/common/store/reducers/index.ts 100.00% <ø> (ø)
...eDiscoveryBanner/components/FseDiscoveryBanner.tsx 100.00% <100.00%> (ø)
...services/fseDiscoveryBanner/store/actions/index.ts 100.00% <100.00%> (ø)
...ervices/fseDiscoveryBanner/store/reducers/index.ts 100.00% <100.00%> (ø)
...pp/ts/store/reducers/backendStatus/remoteConfig.ts 79.29% <100.00%> (+0.68%) ⬆️
...rvices/fseDiscoveryBanner/store/selectors/index.ts 80.00% <80.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5c789...3a64d71. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread apps/main-app/locales/it/index.json Outdated
Co-authored-by: Jacopo Pompilii <Jacopo.pompilii@pagopa.it>

@adelloste adelloste left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 enabled auto-merge July 8, 2026 13:22
@forrest57 forrest57 added this pull request to the merge queue Jul 8, 2026
@forrest57 forrest57 removed this pull request from the merge queue due to a manual request Jul 8, 2026
@forrest57 forrest57 added this pull request to the merge queue Jul 8, 2026
@forrest57 forrest57 removed this pull request from the merge queue due to a manual request Jul 8, 2026
@forrest57 forrest57 added this pull request to the merge queue Jul 8, 2026
Merged via the queue into master with commit dfba458 Jul 8, 2026
12 checks passed
@forrest57 forrest57 deleted the IOCOM-3240-app-implementazione-banner-fse-nella-sezione-messaggi branch July 8, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-FIP IO Foundation - Interazioni & Preferenze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants