[Data Storage] Removing LongBlob from DB#50
Open
frutescens wants to merge 1 commit intopagefaultgames:masterfrom
Open
[Data Storage] Removing LongBlob from DB#50frutescens wants to merge 1 commit intopagefaultgames:masterfrom
frutescens wants to merge 1 commit intopagefaultgames:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, PokeRogue stores both system data and session data in the form of LONGBLOB. LONGBLOB in SQL is able to store around 4 GB, which is unnecessary for both forms of data. This also creates an unnecessary security vulnerability to DDOS.
System data has been downgraded to MEDIUMBLOB which can store around 16.5 MB - which should be plenty of room given future expansions.
Session data has been downgraded to BLOB which can store around 600kb. However, I can see an argument for changing to MEDIUMBLOB since modifiers can bloat the size of the data especially in endless runs.