Add rmdepcheck and fedora-review tests

[LecrisUT]

TODO:

• Write new tests or update the old ones to cover new functionality.
• Make the related tests compatible with packit's contexts
  • rmdepcheck
  • fedora-review ready but postponing the enablement
  • license-validate

Merge after fedora-ci/rmdepcheck-pipeline#12

Also not sure how this would behave when run in prod when the corresponding tests are not yet enabled.

RELEASE NOTES BEGIN

Packit Fedora-CI now runs rmdepcheck and license-validate tests on PRs.

RELEASE NOTES END

[gemini-code-assist]

Code Review

This pull request introduces support for rmdepcheck and fedora-review tests within the Fedora CI workflow by adding dedicated payload generation methods and updating the corresponding integration tests. The review feedback identifies several necessary corrections: the TMT plan names in the implementation should include a leading slash to maintain consistency with conventions and test expectations; the integration tests must be updated to expect the stg branch for the ref field to match the non-production environment logic; and the deployment check should be refactored to compare the enum member directly rather than its string name for improved robustness.

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/5eb43ed3c76e4073aa19c761d3703e65

✔️ pre-commit SUCCESS in 1m 49s
❌ packit-service-tests FAILURE in 4m 03s

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/9d7fdea7a7f340ca9c8ddafa1cfb652f

✔️ pre-commit SUCCESS in 1m 50s
❌ packit-service-tests FAILURE in 4m 00s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/8eb07ece1a5e4329ad69e630a435fb76

✔️ pre-commit SUCCESS in 1m 48s
✔️ packit-service-tests SUCCESS in 4m 02s

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/65450ef8d4ac442b8ad358b6f9eafddf

✔️ pre-commit SUCCESS in 1m 52s
❌ packit-service-tests FAILURE in 3m 00s

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/e33338da55fa4586bca21d5e3305d845

❌ pre-commit FAILURE in 1m 51s
❌ packit-service-tests FAILURE in 3m 29s

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/452bc24f85944fc7ac6ef1db8497a3aa

✔️ pre-commit SUCCESS in 1m 50s
❌ packit-service-tests FAILURE in 2m 59s

[LecrisUT]

@majamassarini this should be all ready right now, so let's move it forward. Btw among the packit roles, who is best to ping about moving some PRs forward? (picked the community-shepherd 🙂)

CC rmdepcheck and license-validate test owners, all good to start running it on PRs? @AdamWill @xsuchy

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/d342823e08774d1baf34558b7deda529

✔️ pre-commit SUCCESS in 1m 52s
❌ packit-service-tests FAILURE in 3m 29s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/4c73e508d5784fe29defb350575faae0

✔️ pre-commit SUCCESS in 1m 55s
✔️ packit-service-tests SUCCESS in 3m 01s

[AdamWill]

CC rmdepcheck and license-validate test owners, all good to start running it on PRs?

For rmdepcheck: with the caveat that we know it'll fail on the individual PRs of a multi-package update case, yeah.

[LecrisUT]

For rmdepcheck: with the caveat that we know it'll fail on the individual PRs of a multi-package update case, yeah.

Don't worry this is only one of 10 other different ways things fail there 😅

[LecrisUT]

@nforro Can we get this moving soon?

[xsuchy]

@LecrisUT can you rebase it please?

[centosinfra-prod-github-app]

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/b0512df89be545de82c78deae39c5ddb

✔️ pre-commit SUCCESS in 1m 55s
❌ packit-service-tests FAILURE in 3m 38s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/08d2328496014110b20002c367942593

✔️ pre-commit SUCCESS in 2m 05s
✔️ packit-service-tests SUCCESS in 3m 39s

[nforro]

LGTM

[centosinfra-prod-github-app]

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/b65544ef8f6d4e0eadaaccacc99e17d5

✔️ pre-commit SUCCESS in 1m 55s