Show model download progress on first start#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds first-run UX improvements for model downloads by implementing download progress tracking and a warmup CLI command. The changes introduce a "Preparing models" TUI step that shows real-time download progress for WhisperX/HuggingFace models, along with a new warmup command to prefetch models before recording sessions.
Changes:
- Added download progress parsing for tqdm/HuggingFace-style output with per-step detail text support in the TUI
- Implemented
ownscribe warmupCLI command to prefetch transcription/diarization models without processing audio - Refactored transcriber model loading into shared methods with optional
prepare_models()hook in the base class
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_transcription.py | Tests for prepare_models lifecycle, download progress hooks, and runtime step routing |
| tests/test_progress.py | Comprehensive tests for download progress parsing, formatting, and TUI detail rendering |
| tests/test_pipeline.py | Tests for run_warmup command and PipelineProgress configuration |
| tests/test_cli.py | Tests for warmup CLI command invocation and parameter handling |
| src/ownscribe/transcription/whisperx_transcriber.py | Core implementation of model preparation, download capture, and progress tracking |
| src/ownscribe/transcription/base.py | Added optional prepare_models() hook to base Transcriber class |
| src/ownscribe/progress.py | Download progress parsing, formatting, and TUI detail line support |
| src/ownscribe/pipeline.py | run_warmup implementation with progress configuration |
| src/ownscribe/cli.py | warmup CLI command with model/language/diarization options |
| README.md | Documentation for warmup command and first-run model download behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds first-run model download UX improvements, a warmup command, and then refines the TUI to avoid regressions and simplify the runtime step flow.
What Changed
WhisperXTranscriber.prepare_models(...)and shared model-loading/download-capture logic.Tests Added / Updated