please add docker image github action 🙏🏻#34
Conversation
|
also can u please make the simple-proxy package public too idk why it would be private but if you have ur reasons then whatever. |
I can't see a package (and I have access to the organization) so I don't think we have one on github |
|
/agentic_review |
Code Review by Qodo
1. Hardcoded DATABASE_URL credentials
|
| tags: | | ||
| # Set latest tag for master branch | ||
| type=raw,value=latest,enable={{is_default_branch}} | ||
| # Use version from package.json | ||
| type=raw,value=${{ steps.package-version.outputs.version }} | ||
| # Use short SHA |
There was a problem hiding this comment.
2. Version tag retargeted 🐞 Bug ⛯ Reliability
The workflow tags every master build with the package.json version, so if the version isn’t bumped on each commit, the same version tag will be overwritten to point at different images over time. This breaks reproducibility and makes rollbacks/debugging unreliable (pulling 2.1.3 on different days yields different binaries).
Agent Prompt
### Issue description
The workflow publishes a Docker tag equal to `package.json`'s version on every push to `master`, which can overwrite the same version tag to point at different images.
### Issue Context
`package.json` typically changes less frequently than commits to `master`, so `2.1.3` (example) would be re-pushed and no longer uniquely identify a build.
### Fix Focus Areas
- .github/workflows/docker-publish.yml[41-54]
### Suggested change
- Gate the raw `package.json` version tag so it is only emitted for tag builds (or remove it entirely and rely on `type=ref,event=tag`). For example, change the version tag line to use an enable condition for tag events (per `docker/metadata-action` syntax), or switch to `type=semver` driven by git tags.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
generated docker image using dockerfile so it automatically for free makes a docker image to pull from instead of having to build it on the host that will deploy it even though theres always a choice i just want to have up to date version on server
Type of change