Skip to content

Conversation

@citrus-it
Copy link
Contributor

Currently if one runs propolis on a system which does not have a new
enough viona API, a stacktrace like this is generated.

failed to enable promisc mode on vnic0: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }
called `Result::unwrap()` on an `Err` value: Os { code: 25, kind: Uncategorized, message: "Inappropriate ioctl for device" }
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: propolis::hw::virtio::viona::PciVirtioViona::new_with_queue_sizes
   4: propolis::hw::virtio::viona::PciVirtioViona::new

Since we don't currently support anything older than the V6 API in
propolis we should at least produce a useful error message to the
operator. It would be possible to fall back to the older API if we
wish to implement that.

@citrus-it citrus-it requested a review from iximeow January 23, 2026 13:25
Currently if one runs propolis on a system which does not have a new
enough viona API, a stacktrace like this is generated.

    failed to enable promisc mode on vnic0: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }
    called `Result::unwrap()` on an `Err` value: Os { code: 25, kind: Uncategorized, message: "Inappropriate ioctl for device" }
    stack backtrace:
       0: __rustc::rust_begin_unwind
       1: core::panicking::panic_fmt
       2: core::result::unwrap_failed
       3: propolis::hw::virtio::viona::PciVirtioViona::new_with_queue_sizes
       4: propolis::hw::virtio::viona::PciVirtioViona::new

Since we don't currently support anything older than the V6 API in
propolis we should at least produce a useful error message to the
operator. It would be possible to fall back to the older API if we
wish to implement that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants