implement support for query parameters that allow multiple values#1553
Draft
implement support for query parameters that allow multiple values#1553
Conversation
This switches our querystring parsing to use serde_qs, which seems more specifically focused on that, from serde_urlencoded. One drawback is that serde_qs permits a query parameter for which a single value is permitted to appear multiple times within the query string without reporting an error. Instead it silently accepts the last one. If we believe that this is an obstacle, I believe we could augment the `Config` object in serde_qs to optionally turn this modality into an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches our querystring parsing to use serde_qs, which seems more specifically focused on that, from serde_urlencoded. One drawback is that serde_qs permits a query parameter for which a single value is permitted to appear multiple times within the query string without reporting an error. Instead it silently accepts the last one.
If we believe that this is an obstacle, I believe we could augment the
Configobject in serde_qs to optionally turn this modality into an error.