Two-column Standard HUD when Diagnostics is on#77
Closed
oliversluke wants to merge 1 commit into
Closed
Conversation
The Standard statistics HUD fits the screen comfortably on its own, but enabling Diagnostics appends the whole Debug section (~15-25 extra lines, several of them wrapping sentences), roughly doubling the panel height so the lower rows run off the bottom of the screen. When Diagnostics is on, lay the Standard HUD out in two columns — core stats (Network/Video/Audio/Session) on the left, Debug on the right — which roughly halves the height so everything stays visible. Compact and Standard-without-Diagnostics are unchanged (single column). Splits the panel/column layout helpers so the fixed 380pt width now lives on each column rather than the whole panel. Complements owenselles#76 (which stops the tall HUD from zooming the video); this keeps the extra Diagnostics rows on screen. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
82ebb1f to
0d85c7b
Compare
Contributor
Author
|
Folded into #76, which now covers the video-zoom fix, the two-column Standard HUD, and the removal of the redundant Debug lines together (they're all the same 'tall Standard + Diagnostics HUD' concern, and testing them separately was causing confusion about which build had what). Closing this in favor of #76. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Standard statistics HUD fits the screen comfortably on its own (~18 rows), but enabling Diagnostics appends the entire Debug section — ~15–25 extra lines, several of them full-width wrapping sentences (decoded-video status, color-diagnostic status, display-layer metrics). That roughly doubles the panel height, so the lower rows run off the bottom of the screen and can't be read.
Change
When Diagnostics is on, lay the Standard HUD out in two columns — core stats (Network / Video / Audio / Session) on the left, Debug on the right — which roughly halves the height so everything stays visible. Compact and Standard-without-Diagnostics are unchanged (single column).
Small refactor of the layout helpers: the fixed 380 pt width moves from the whole panel onto a new
columnhelper, andpanelnow just applies the font, padding, and background. Each column is 380 pt, so the two-column panel is wider (top-trailing anchored, as before).Relationship to #76
#76 stops a tall HUD from zooming the video (moves the HUD into an
.overlay). This PR is the complement: it keeps the extra Diagnostics rows on screen instead of overflowing. They're independent (different files) and can merge in either order; together you get no zoom and all rows visible.Testing
Simulator build + SwiftFormat + SwiftLint (strict) pass. Worth a device check with Standard + Diagnostics enabled to confirm the two columns fit and read well.
🤖 Generated with Claude Code