Skip to content

πŸ” Echo: deduplicate navigator.clipboard.writeText β†’ copyToClipboard in clipboard.js#95

Draft
ovidiuvio wants to merge 1 commit into
mainfrom
echo-deduplicate-clipboard-5118328311516655452
Draft

πŸ” Echo: deduplicate navigator.clipboard.writeText β†’ copyToClipboard in clipboard.js#95
ovidiuvio wants to merge 1 commit into
mainfrom
echo-deduplicate-clipboard-5118328311516655452

Conversation

@ovidiuvio

Copy link
Copy Markdown
Owner

πŸ” What was duplicated

The navigator.clipboard.writeText sequence and subsequent error/success toast handling was inline inside:

  • frontend/src/components/SpacesList.svelte
  • frontend/src/components/SpaceViewer.svelte
  • frontend/src/components/renderers/TreeNode.svelte
  • frontend/src/components/RelicForm.svelte
  • frontend/src/App.svelte

βœ… Now lives in

copyToClipboard inside frontend/src/services/utils/clipboard.js.

πŸ“ Call sites updated

  • frontend/src/components/SpacesList.svelte
  • frontend/src/components/SpaceViewer.svelte
  • frontend/src/components/renderers/TreeNode.svelte
  • frontend/src/components/RelicForm.svelte
  • frontend/src/App.svelte

πŸ”’ Behaviour unchanged. All copies replaced. All tests pass.


PR created automatically by Jules for task 5118328311516655452 started by @ovidiuvio

Extracted inline `navigator.clipboard.writeText` and its associated toast notifications across 5 frontend components into a single shared utility `copyToClipboard` in `frontend/src/services/utils/clipboard.js`. This resolves structural duplication of the clipboard copy logic and standardizes behavior.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant