feat: distinguish server/login errors with clear notifications#382
Open
simon-wilmes wants to merge 1 commit into
Open
feat: distinguish server/login errors with clear notifications#382simon-wilmes wants to merge 1 commit into
simon-wilmes wants to merge 1 commit into
Conversation
Previously, adding a wrong server URL was accepted silently and login failures only showed a generic "Login failed." (or a bare HTTP status like "400"), with network errors swallowed entirely. The API layer now classifies failures into machine-readable categories (unreachable / not-overleaf / unauthorized / unknown) and the display layer maps them to localized, user-facing messages: - addServer probes the URL (unauthenticated, no credentials, manual redirect, 5s timeout) and warns with "Add anyway" if it is unreachable or does not look like an Overleaf/ShareLaTeX server. - passportLogin surfaces the server's own message for rejected logins (400/401/200), e.g. "Email address is invalid", falling back to a localized message when only an i18n key is returned. - cookiesLogin treats a redirect to /login as an invalid/expired session rather than misreporting a valid server as "not an Overleaf server". Closes overleaf-workshop#381 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, adding a wrong server URL was accepted silently and login failures only showed a generic "Login failed." (or a bare HTTP status like "400"), with network errors swallowed entirely.
The API layer now classifies failures into machine-readable categories (unreachable / not-overleaf / unauthorized / unknown) and the display layer maps them to localized, user-facing messages:
Closes #381