Fix UI dataset list to recognize symbolic links#685
Open
diodiogod wants to merge 1 commit intoostris:mainfrom
Open
Fix UI dataset list to recognize symbolic links#685diodiogod wants to merge 1 commit intoostris:mainfrom
diodiogod wants to merge 1 commit intoostris:mainfrom
Conversation
The dataset scanner was not detecting symbolic links pointing to directories. This commit adds support for symlinks by: - Checking if a dirent is a symbolic link - Using fs.statSync to verify the symlink points to a directory - Gracefully handling broken symlinks This allows users to organize datasets using symbolic links without duplicating data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the dataset scanner in the UI to recognize symbolic links pointing to directories.
Problem
The current implementation only checks for regular directories using
isDirectory(), which doesn't follow symbolic links. This prevents users from organizing datasets using symlinks without duplicating data.Solution
fs.statSync()to verify the symlink points to a directoryChanges
ui/src/app/api/datasets/list/route.tsto detect both regular directories and symbolic linksTesting
Tested with symbolic links on Windows and they now appear correctly in the dataset list.