fix: handle HTML void elements in markdown attribute processing#126
Merged
Conversation
<br>, <hr>, <img>, and other HTML void elements inside markdown="1" blocks caused an "unexpected EOF" error because the HTML tokenizer depth tracker incremented on their start tags but never saw matching end tags. Skip depth increment for void elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66 —
<br>tags (and other HTML void elements) insidemarkdown="1"blocks caused an "unexpected EOF" error.Root cause: The HTML tokenizer depth tracker in
processInnerMarkdownandcopyContentincremented depth on everyStartTagToken, but void elements (<br>,<hr>,<img>, etc.) never produce a matchingEndTagToken. This caused the depth counter to never reach 0, resulting in EOF when the tokenizer ran out of input.Fix: Skip depth increment for HTML void elements. Both
<br>(HTML5) and<br/>(XHTML) forms are handled correctly.Test plan
go test ./...passes<br>,<hr>,<img>insidemarkdown="1"andmarkdown="0"blocks