Update OSCAL part names and subclass reqs into items #452
+46
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
This PR updates the names of the OSCAL parts to use the valid names according to the nested levels. We also now subclass each control item to its own part. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the OSCAL validation failures from the new validation performed by the oscal-club action. The oscal generator now uses the proper part depending on the nesting level. The resulting oscal code now subclasses each control requirement (eg
OSPS-AC-03.01) into items in the control definition.Fixes #451
Supersedes #450
Signed-off-by: Adolfo García Veytia (Puerco) puerco@carabiner.dev