Skip to content

[WIP] Add button to allow CPS as input data source #831

Closed
GoFroggyRun wants to merge 4 commits into
ospc-org:masterfrom
GoFroggyRun:add_cps
Closed

[WIP] Add button to allow CPS as input data source #831
GoFroggyRun wants to merge 4 commits into
ospc-org:masterfrom
GoFroggyRun:add_cps

Conversation

@GoFroggyRun

Copy link
Copy Markdown
Contributor

No description provided.

@GoFroggyRun

Copy link
Copy Markdown
Contributor Author

@hdoupe this is how I'd like to add the CPS button. I'm having trouble to have those options displayed properly, even if for most part I was mimicking the "Start Year" button.

@GoFroggyRun

GoFroggyRun commented Mar 1, 2018

Copy link
Copy Markdown
Contributor Author

I'm confused why the new button shows nothing: when I substitute start_years for data_sources, and start_year for default_source, the drop down does show different years as specified in constants.py. But I can't quite figure out why data_sources, default_source won't work.

@hdoupe

hdoupe commented Mar 2, 2018

Copy link
Copy Markdown
Collaborator

@GoFroggyRun this makes sense to me. In PR #789, I tried to mimic the start year behavior and did not have much success either. Would you mind fixing the merge conflict so that I can check this branch out locally and tinker with it some?

@GoFroggyRun

Copy link
Copy Markdown
Contributor Author

@hdoupe Thanks! Conflicts are resolved.

@hdoupe

hdoupe commented Mar 2, 2018

Copy link
Copy Markdown
Collaborator

Thanks @GoFroggyRun

@GoFroggyRun

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #835

@GoFroggyRun GoFroggyRun closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants