feat: add scopes validator for logical evalulation#1143
Open
JarekKa wants to merge 7 commits intoory:masterfrom
Open
feat: add scopes validator for logical evalulation#1143JarekKa wants to merge 7 commits intoory:masterfrom
JarekKa wants to merge 7 commits intoory:masterfrom
Conversation
092d073 to
9fd1709
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
- Coverage 78.16% 77.72% -0.45%
==========================================
Files 80 80
Lines 3898 4036 +138
==========================================
+ Hits 3047 3137 +90
- Misses 576 618 +42
- Partials 275 281 +6 ☔ View full report in Codecov by Sentry. |
6 tasks
Author
|
I couldn't reproduce linter check issues locally. Dockers issues seem to pop up in other PR too. https://github.com/ory/oathkeeper/pull/1138/checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature introduces logical "OR" in the scope validation. Any match would suffice here. Example below. Details in issue.
Example of a match:
"required_scope": ["scope1", "scope2"]
token scopes: "scope1"
Related issue(s)
#1129
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
Corresponding docs PR: ory/docs#1608