chore: pin Rust toolchain to 1.94.0 and declare MSRV#8
Open
orrinfrazier wants to merge 1 commit into
Open
Conversation
Add a `rust-toolchain.toml` pinning the toolchain to 1.94.0 and set `[workspace.package].rust-version = "1.94"`, inherited by all 30 member crates, so non-Guix CI and the public release binaries no longer float on whatever `stable` is current at run time. - rust-toolchain.toml: channel = "1.94.0" + rustfmt/clippy components - [workspace.package].rust-version = "1.94" (MSRV tracks the pin by a latest-stable-only policy, documented inline) - rust-version.workspace = true added to every member crate - ci.yml / release.yml / deny.yml: `toolchain: stable` -> `1.94.0` (dtolnay/rust-toolchain does not read rust-toolchain.toml, so the version is named in each workflow; doc.yml + fuzz.yml stay nightly) - constants: a std-only test guarding the pin/MSRV invariants, globbing all workflows (allowlisting nightly) and iterating every member so a new job left on stable or a crate missing inheritance is caught Implements issues/S06-1-msrv-toolchain-pin.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Summary
rust-toolchain.tomland declares an MSRV of 1.94 via[workspace.package].rust-version, inherited by all 30 member crates.ci.yml,release.yml, anddeny.ymlso non-Guix CI and the public release binaries stop floating on whateverstableis current at run time.issues/S06-1-msrv-toolchain-pin.md.Why
Without a pinned toolchain, a new
stablerelease can silently break CI or change release-binary output, reproducible builds can't be guaranteed for the non-Guix matrix, and contributors/distros have no declared minimum supported Rust version.Changes
rust-toolchain.toml(new):channel = "1.94.0", componentsrustfmt+clippy.[workspace.package].rust-version = "1.94"+rust-version.workspace = trueon every member crate (scripted across 30 manifests).cargo metadatareportsrust_version = 1.94for all 30 members.toolchain: stable→toolchain: 1.94.0(with a sync comment).dtolnay/rust-toolchaindoes not readrust-toolchain.toml, so the version is named explicitly in each workflow.doc.ymlandfuzz.ymlremain onnightlyintentionally (cargo-doc features / cargo-fuzz).constants/src/lib.rs: astd-only#[cfg(test)] mod toolchain_pinthat locks the invariants — globs all.github/workflows/*.yml(asserting notoolchain: stable, pinned version everywhere, nightly workflows allowlisted) and iterates all workspace members (asserting each inherits the MSRV). Globbing/iterating rather than sampling means a future job left onstableor a new crate missing inheritance is caught.How to test
The drift guard was verified negatively: injecting a workflow on
toolchain: stableand removing inheritance from a member each make the corresponding test fail.Review notes
Reviewed via 3-way cross-family consensus (Claude + Gemini + Codex, opus adjudicator). Consensus strengthened the drift-guard test from a hardcoded 3-file/3-crate sample to globbing all workflows + iterating all members. Rejected with rationale: pinning
doc.yml/fuzz.ymlto 1.94.0 (nightly is required there), removing/faking a lower MSRV, and adding thewasm32target torust-toolchain.toml(CI installs it per-job; global cost not justified).