feat: ability to use only precomputed point predictions#4
Open
FlorentRamb wants to merge 3 commits intooracle:mainfrom
Open
feat: ability to use only precomputed point predictions#4FlorentRamb wants to merge 3 commits intooracle:mainfrom
FlorentRamb wants to merge 3 commits intooracle:mainfrom
Conversation
Signed-off-by: Florent Rambaud <flo.rambaud@gmail.com>
Signed-off-by: Florent Rambaud <flo.rambaud@gmail.com>
|
Hi, @FlorentRamb great to see you working on this and improving the code! just to check how this works, is this allowing you to do a similar pre-computation in prediction as we do when training the model? i.e. when training we calculate the point predictions once at the beginning and then pass these predictions around when training all the mace parameters. So is this MR allowing you to do this after training? |
Author
|
If I'm understanding well, yes indeed! The optional parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to train and use a macest model only from precomputed point predictions. This allows to have no reference to the point predcition model in the macest model, which makes the loading/saving and usage of these models easier. The following changes are introduced:
modelorpoint_pred_modelargument in__init__becomes optionalprec_point_predsis added toModelWithConfidence.fit,ModelWithConfidence.predict_confidence_of_point_prediction,ModelWithPredictionInterval.predict_intervalandModelWithPredictionInterval.fitupdate_empirical_conflict_constantis added to_TrainingHelper.fit. It allows to skip the stepfind_conflicting_predictionsSigned-off-by: Florent Rambaud flo.rambaud@gmail.com