Skip to content

feat: fixed has_binary flag condition#1333

Open
AbhinavPradeep wants to merge 1 commit intomainfrom
abhinav/fix-binary-flag
Open

feat: fixed has_binary flag condition#1333
AbhinavPradeep wants to merge 1 commit intomainfrom
abhinav/fix-binary-flag

Conversation

@AbhinavPradeep
Copy link
Contributor

Summary

Fixed the condition for has_binaries flag to be the presence of any non-pure wheels as compared to requiring existance of a pure wheel.

Description of changes

Changed function has_pure_wheel to has_non_pure_wheel.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 18, 2026
Copy link
Member

@behnazh-w behnazh-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an integration test for a package that only releases an sdist to make sure the has_binaries field is populated correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants