feat: Implement account registration functionality#59
Open
Roktiiv wants to merge 1 commit into
Open
Conversation
This commit introduces the ability to register new ProtonMail accounts
through the API client.
Key changes include:
- New methods in the `ProtonMail` class:
- `get_username_available`: Checks if a username is available.
- `send_verification_code`: Sends a verification code to an email address.
- `create_user`: Creates a new user account, handling SRP and CAPTCHA.
- Updated SRP helper functions in `utils/pysrp.py` to support
verifier generation for new accounts.
- New data models in `models.py` for registration-related requests
and responses.
- New exception classes in `exceptions.py` for registration-specific errors.
- Updated `constants.py` with necessary values for registration.
- Refactored CAPTCHA handling in `client.py` to be more generic and
reusable by both login and registration flows.
- Added a comprehensive suite of unit tests in `tests/test_registration.py`
covering various scenarios, including CAPTCHA.
- Updated `README.md` with documentation and examples for the new
registration features.
All new tests are passing.
Author
|
god |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to register new ProtonMail accounts through the API client.
Key changes include:
ProtonMailclass:get_username_available: Checks if a username is available.send_verification_code: Sends a verification code to an email address.create_user: Creates a new user account, handling SRP and CAPTCHA.utils/pysrp.pyto support verifier generation for new accounts.models.pyfor registration-related requests and responses.exceptions.pyfor registration-specific errors.constants.pywith necessary values for registration.client.pyto be more generic and reusable by both login and registration flows.tests/test_registration.pycovering various scenarios, including CAPTCHA.README.mdwith documentation and examples for the new registration features.All new tests are passing.