Fix bug in XmlComment.asOpenTag() where comment was not rendered on empty _name#11
Open
elementgreen wants to merge 1 commit intoopticron:masterfrom
Open
Fix bug in XmlComment.asOpenTag() where comment was not rendered on empty _name#11elementgreen wants to merge 1 commit intoopticron:masterfrom
elementgreen wants to merge 1 commit intoopticron:masterfrom
Conversation
…name was empty (always the case for comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmlComment doesn't use the _name field so this check was probably a copy/paste error. It resulted in comments not being written when converting from the DOM objects to a rendered XML string.