Update Bookinfo source to upstream Istio 1.30.1 (keep ratings customization)#2
Open
winggundamth wants to merge 1 commit into
Open
Update Bookinfo source to upstream Istio 1.30.1 (keep ratings customization)#2winggundamth wants to merge 1 commit into
winggundamth wants to merge 1 commit into
Conversation
…h/DB-name/tests) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the 3-year-old (2023-05) Bookinfo source to upstream Istio 1.30.1, preserving the local ratings enhancements.
Per service
Dockerfile(python:3.13.3), Tailwind UI. (Old unreferencedstatic/bootstrap/+jquery left in place — prune if desired.)Dockerfile+Gemfile.lock.reviews-application/+reviews-wlpcfg/Gradle multi-project layout; open-liberty 24.0.0.12 runtime.MONGO_DB_USERNAME/PASSWORD), configurableMONGO_DB_NAME(vs upstream's hardcodedtest), and jest tests. Removed the deprecateduseNewUrlParser/useUnifiedTopologyflags (noise on the pinnedmongodb ^3.6.0, would error on 4.x+).src/mongodb/,src/mysql/,docker-bake.hcl,build-services.sh.Recommendation on the ratings customization
Keep it — it's strictly more capable than upstream (auth + configurable DB name + tests). Flagged: if you deploy the upstream
src/mongodb/sample, setMONGO_DB_NAME=testso it matches the seed data.Review notes
ratings.jssyntax + JSON validated).build-services.shassumes the full istio repo layout — reference only in this fork.🤖 Generated with Claude Code