dns/bind: add SVCB record type support#5508
Merged
Merged
Conversation
Adds SVCB to the Record model OptionValues so RFC 9460/9461 SVCB records (e.g. _dns DDR records for encrypted-DNS discovery) can be created via the plugin GUI/API. BIND 9.18+ supports SVCB natively; the plugin validation rejected the type before it reached named. One-line change, complements the HTTPS record type (opnsense#5425).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SVCBto the BIND plugin's record-type options so RFC 9460/9461 SVCB records can be created via the GUI/API.Describe the problem
The plugin's record model rejected the
SVCBtype before it reachednamed, so SVCB records (notably_dnsrecords for Discovery of Designated Resolvers, RFC 9461) couldn't be created. BIND 9.18+ supports SVCB natively.Describe the proposed solution
One-line addition of
SVCBto theRecord.xmlOptionValues (alphabetically betweenSSHFPandTLSA). No template changes needed —namedrenders SVCB rdata directly.This complements #5425 (HTTPS record type);
HTTPSis the HTTPS-specific form of SVCB, this adds the generalSVCBtype. Scoped to this single change.