Conversation
7ddda9f to
06bd3a0
Compare
This method will be responsible for handling versions
Also makes it work between Version and Agile::Sprint
56ec3b8 to
9f37393
Compare
dombesz
requested changes
Mar 13, 2026
Contributor
dombesz
left a comment
There was a problem hiding this comment.
Overall works as expected, I found a few code structure related issues and one permission check issue, nothing serious.
dombesz
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/72849
Note: We have a name clash. With Sprint, I mean the legacy Sprint inheriting from Version. For the new style sprint, I will explicitly write Agile::Sprint.
Drag and drop works:
When moving a Story from any sprint type to another, we try to retain the Version assigned to the Work Package. The rule is: if the assigned Version is not configured to be
used_as_backlog?, we can keep the Version association. However, if the Version poses as backlog, we must remove the association, or else the Story would exist in an Agile::Sprint and a Sprint at the same time.The feature flag is not checked within the stories controller. As you can only move a Story to an already existing Agile::Sprint, I think this is acceptable. Having the feature enabled is required to create an Agile::Sprint. Modifying one should be allowed even without the flag.
Caveats
Work Packages do not consider and update their
positionwith Agile::Sprint in mind. Hence, you can drag and drop to an Agile::Sprint - but once the Work Package is in an Agile::Sprint, the position will not work as expected. This issue is out of scope for the current PR and will be handled in WP 73093