🐛 Fix deprecation conditions showing install errors and improve condition semantics #2296

camilamacedo86 · 2025-11-01T07:58:25Z

Fixes deprecation conditions showing install errors instead of actual deprecation status.

Closes: #2008
Addresses: Comment #3524229770, Comment #3524241806

Problems Fixed

1. Install errors leaked into deprecation conditions

When installation failed, the error appeared in ALL conditions including deprecation ones:

- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validating bundle: dependency not supported"  # ❌ Wrong place!

Users couldn't tell if something was actually deprecated.

2. Wrong bundle checked during upgrades

When upgrading v1.0.0 → v1.0.1, deprecation showed v1.0.1's status even when the upgrade failed.

This violates Kubernetes convention: status must show actual state, not desired state.

3. Too much YAML clutter

Every ClusterExtension showed 4 False deprecation conditions:

conditions:
  - type: Deprecated
    status: "False"              # Noise
  - type: PackageDeprecated
    status: "False"              # Noise
  - type: ChannelDeprecated
    status: "False"              # Noise
  - type: BundleDeprecated
    status: "False"              # Noise

Users complained about cluttered output.

Changes Made

What we do now

Situation	What we show
IS deprecated	Condition with `status: True`
NOT deprecated	Condition absent (no clutter!)
Can't check catalog	Condition with `status: Unknown`
No bundle installed	BundleDeprecated shows `status: Unknown, reason: Absent`

Key improvements

Install errors stay separate
- Errors → Progressing and Installed conditions only
- Deprecation → catalog data only (never errors)
Use installed bundle (not resolved)
- Checks what's actually running
- Follows Kubernetes "status = actual state" convention
Remove False conditions
- Absent = not deprecated
- 60% less YAML clutter
Correct reason values
- Deprecated → when True
- DeprecationStatusUnknown → when Unknown
- Absent → when no bundle installed (BundleDeprecated only)

Before/After Comparison

What Changed	Main (Before)	This PR (After)
Install errors	Leak into deprecation conditions ❌	Stay in Progressing/Installed only ✅
Catalog unavailable	Shows `False` (misleading) ❌	Shows `Unknown` (honest) ✅
Bundle reference	Uses resolved bundle ❌	Uses installed bundle ✅
Not deprecated	Shows `False` (noisy) ❌	Condition absent (clean!) ✅
Reason values	Always `Deprecated` ❌	Context-specific ✅

Examples

Example 1: Not Deprecated (Clean!)

Before:

conditions:
  - {type: Deprecated, status: "False"}
  - {type: PackageDeprecated, status: "False"}
  - {type: ChannelDeprecated, status: "False"}
  - {type: BundleDeprecated, status: "False"}
  - {type: Installed, status: "True"}
  - {type: Progressing, status: "True"}

After:

conditions:
  - {type: Installed, status: "True"}
  - {type: Progressing, status: "True"}
  # ✅ No deprecation conditions = not deprecated

Example 2: Install Error (Bug #2008)

Before:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validation failed: dependency not supported"  # ❌ Error leaked!

After:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
# ✅ PackageDeprecated absent (error didn't leak!)

Example 3: Catalog Removed

Before:

- type: BundleDeprecated
  status: "False"              # ❌ Misleading: claims "not deprecated"
  reason: Failed

After:

- type: BundleDeprecated
  status: "Unknown"            # ✅ Honest: we can't check
  reason: DeprecationStatusUnknown

Demos

Watch the fixes in action:

Scenarios 1-2 (Clean YAML + Unknown): https://asciinema.org/a/Ej0ZeWEXnCvzf2SNuIkF4FDh9
Scenario 3 (Error leak fix Install error message getting propagated to most conditions #2008): https://asciinema.org/a/frKLqoOHWRGkvJNFMfO0hysdy
Scenario 4 (Catalog removed): https://asciinema.org/a/ZGWA3YQH1kmS9AKHuObPzlSi4

netlify · 2025-11-01T07:58:30Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`8b6cfef`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6957c18a9cfe3f00083c94b2
😎 Deploy Preview	https://deploy-preview-2296--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull Request Overview

This PR refactors deprecation status handling in ClusterExtension reconciliation to ensure deprecation conditions accurately reflect catalog data and installed bundle state, preventing install/validation errors from leaking into deprecation conditions.

Moved deprecation status updates to a deferred function that runs at the end of reconciliation
Changed BundleDeprecated condition to use Unknown status with ReasonAbsent when no bundle is installed
Updated test expectations to handle multiple possible error messages for sourceType validation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
internal/operator-controller/controllers/clusterextension_controller.go	Refactored deprecation status logic with deferred updates and new condition semantics for uninstalled bundles
internal/operator-controller/controllers/clusterextension_controller_test.go	Added tests for deprecation handling with resolution failures and applier failures; updated test expectations for BundleDeprecated conditions
test/e2e/cluster_extension_install_test.go	Updated e2e tests to verify deprecation conditions in success and failure scenarios
internal/operator-controller/controllers/clusterextension_admission_test.go	Enhanced sourceType validation test to handle multiple possible error message formats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller.go

internal/operator-controller/controllers/clusterextension_admission_test.go

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller.go

codecov · 2025-11-01T08:46:07Z

Codecov Report

❌ Patch coverage is 98.83721% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.87%. Comparing base (0f92032) to head (8b6cfef).

Files with missing lines	Patch %	Lines
...er/controllers/clusterextension_reconcile_steps.go	96.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   68.82%   68.87%   +0.04%     
==========================================
  Files         100      100              
  Lines        7641     7665      +24     
==========================================
+ Hits         5259     5279      +20     
- Misses       1947     1951       +4     
  Partials      435      435

Flag	Coverage Δ
e2e	`43.91% <72.09%> (+0.09%)`	⬆️
experimental-e2e	`13.63% <0.00%> (-0.05%)`	⬇️
unit	`57.19% <98.83%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextension_controller_test.go:1

The assertion require.Contains(ct, []string{...}, cond.Reason) is semantically backwards. The Contains function expects a slice as the second argument and the search item as the first. This should be require.Contains(ct, cond.Reason, []string{ocv1.ReasonFailed, ocv1.ReasonAbsent}) or use require.True(ct, slices.Contains([]string{ocv1.ReasonFailed, ocv1.ReasonAbsent}, cond.Reason)).

package controllers_test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller.go

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller.go

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller.go

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

api/v1/clusterextension_types.go

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller_test.go

api/v1/common_types.go

internal/operator-controller/conditionsets/conditionsets.go

openshift-ci · 2026-01-02T12:42:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [pedjak]
~~docs/OWNERS~~ [pedjak]
~~helm/OWNERS~~ [pedjak]
~~internal/operator-controller/OWNERS~~ [pedjak]
~~manifests/OWNERS~~ [pedjak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextension_controller_test.go

Deprecation conditions now only show what matters: - When deprecated: condition shows "True" with deprecation message - When not deprecated: condition is absent (no clutter!) - When we can't check: condition shows "Unknown" This fixes three problems: 1. Install errors were leaking into deprecation conditions 2. Catalog unavailable showed "False" instead of "Unknown" 3. BundleDeprecated was checking the wrong bundle (resolved vs installed) Also improved the code: - Simpler logic (clear all, then add only what's needed) - Better reason values (Deprecated, DeprecationStatusUnknown, Absent) - Comprehensive test coverage for all scenarios Assisted-by: Cursor

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

camilamacedo86 · 2026-01-02T17:30:50Z

Hey @joelanford — all your comments have been addressed.

We also have an RFC here: https://docs.google.com/document/d/1_XtISZ74rsd9-Zh9oQje1mEHjAfx0CHlf_50UJkXHTQ
.
In the doc description you’ll find the list of issues fixed, plus demos with examples.

I think it’s ready to 🚀 now.

c/c @pedjak @perdasilva @grokspawn

Copilot AI review requested due to automatic review settings November 1, 2025 07:58

camilamacedo86 requested a review from a team as a code owner November 1, 2025 07:58

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2025

openshift-ci bot requested a review from dtfranz November 1, 2025 07:58

openshift-ci bot requested a review from oceanc80 November 1, 2025 07:58

Copilot AI reviewed Nov 1, 2025

View reviewed changes

camilamacedo86 force-pushed the fix-issue-conditions branch from 0891f37 to 4f61e6a Compare November 1, 2025 08:27

Copilot AI review requested due to automatic review settings November 1, 2025 08:33

camilamacedo86 force-pushed the fix-issue-conditions branch from 4f61e6a to 2b26273 Compare November 1, 2025 08:33

Copilot AI reviewed Nov 1, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-issue-conditions branch from 2b26273 to ad9ccfd Compare November 1, 2025 08:46

camilamacedo86 changed the title ~~WIP: 🐛 (fix):Fix deprecation conditions leaking install errors~~ 🐛 (fix):Fix deprecation conditions leaking install errors Nov 1, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2025

camilamacedo86 requested review from Copilot, joelanford and perdasilva November 1, 2025 08:47

Copilot AI reviewed Nov 1, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Show resolved Hide resolved

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-issue-conditions branch from ad9ccfd to a6d0678 Compare November 1, 2025 09:31

camilamacedo86 requested a review from Copilot November 1, 2025 09:32

Copilot AI reviewed Nov 1, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-issue-conditions branch from a6d0678 to 287bede Compare November 3, 2025 09:38

camilamacedo86 requested a review from Copilot November 3, 2025 10:10

Copilot AI reviewed Nov 3, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

perdasilva reviewed Nov 3, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-issue-conditions branch from 287bede to b2da76f Compare November 3, 2025 12:16

perdasilva reviewed Nov 3, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

perdasilva reviewed Nov 3, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

perdasilva reviewed Nov 3, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextension_controller.go Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of camilamacedo86 January 2, 2026 11:43 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

api/v1/clusterextension_types.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-issue-conditions branch from 4b6fc4e to 0dcaea9 Compare January 2, 2026 12:00

camilamacedo86 changed the title ~~🐛 report Unknown for deprecation status when catalog unavailable and prevent error leak~~ WIP 🐛 report Unknown for deprecation status when catalog unavailable and prevent error leak Jan 2, 2026

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026

Copilot AI review requested due to automatic review settings January 2, 2026 12:26

camilamacedo86 force-pushed the fix-issue-conditions branch from 0dcaea9 to 1e4f932 Compare January 2, 2026 12:26

Copilot started reviewing on behalf of camilamacedo86 January 2, 2026 12:26 View session

camilamacedo86 changed the title ~~WIP 🐛 report Unknown for deprecation status when catalog unavailable and prevent error leak~~ WIP 🐛 Fix deprecation conditions showing install errors and improve condition semantics Jan 2, 2026

Copilot AI reviewed Jan 2, 2026

View reviewed changes

camilamacedo86 force-pushed the fix-issue-conditions branch from 1e4f932 to 8b8bd6b Compare January 2, 2026 12:39

Copilot AI review requested due to automatic review settings January 2, 2026 12:42

camilamacedo86 force-pushed the fix-issue-conditions branch from 8b8bd6b to 5dccbaa Compare January 2, 2026 12:42

Copilot started reviewing on behalf of camilamacedo86 January 2, 2026 12:42 View session

camilamacedo86 force-pushed the fix-issue-conditions branch from 5dccbaa to edc779e Compare January 2, 2026 12:44

Copilot AI reviewed Jan 2, 2026

View reviewed changes

camilamacedo86 force-pushed the fix-issue-conditions branch from edc779e to 1bdded5 Compare January 2, 2026 12:53

camilamacedo86 changed the title ~~WIP 🐛 Fix deprecation conditions showing install errors and improve condition semantics~~ 🐛 Fix deprecation conditions showing install errors and improve condition semantics Jan 2, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026

camilamacedo86 changed the title ~~🐛 Fix deprecation conditions showing install errors and improve condition semantics~~ WIP 🐛 Fix deprecation conditions showing install errors and improve condition semantics Jan 2, 2026

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026

Copilot AI review requested due to automatic review settings January 2, 2026 13:00

camilamacedo86 force-pushed the fix-issue-conditions branch from 1bdded5 to 8b6cfef Compare January 2, 2026 13:00

Copilot started reviewing on behalf of camilamacedo86 January 2, 2026 13:01 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

camilamacedo86 changed the title ~~WIP 🐛 Fix deprecation conditions showing install errors and improve condition semantics~~ 🐛 Fix deprecation conditions showing install errors and improve condition semantics Jan 2, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026

🐛 Fix deprecation conditions showing install errors and improve condition semantics #2296

Are you sure you want to change the base?

🐛 Fix deprecation conditions showing install errors and improve condition semantics #2296

Conversation

camilamacedo86 commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problems Fixed

1. Install errors leaked into deprecation conditions

2. Wrong bundle checked during upgrades

3. Too much YAML clutter

Changes Made

What we do now

Key improvements

Before/After Comparison

Examples

Example 1: Not Deprecated (Clean!)

Example 2: Install Error (Bug #2008)

Example 3: Catalog Removed

Demos

Uh oh!

netlify bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

codecov bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Jan 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

camilamacedo86 commented Nov 1, 2025 •

edited

Loading

netlify bot commented Nov 1, 2025 •

edited

Loading

codecov bot commented Nov 1, 2025 •

edited

Loading