Enable configurable storageClass and size for H2 PVC

[Copilot]

• Explore repository structure and understand current PVC configuration
• Add persistence.storageClass and persistence.size fields to values.yaml
• Update persistentvolumeclaim.yaml template to use the new values
• Update values.schema.json to include the new persistence fields
• Make persistence.size conditional in the PVC template (consistent with storageClass)
• Reduce default PVC size from 1Gi to 256Mi (more appropriate for H2 demo/test usage)
• Make persistence comments db-agnostic (remove H2-specific references)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Enable setting storageClass and size for PVC</issue_title>
<issue_description>Storage class and size for PVC should be configurable via values.yaml.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Enable setting storageClass and size for PVC #16

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[kthoms]

@copilot Although it was the previous default, isn't 1Gi too much for the default? Especially when using h2?

[Copilot]

Reduced the default to 256Mi in ad622b7, which is more appropriate for H2 in demo/test scenarios.

[kthoms]

@copilot Aren't the persistence settings also valid for other DB kinds than h2? Then the comment should be db agnostic.

[Copilot]

Updated in ad622b7 — comments now say "Storage class for the PVC" and "Size of the PVC" without referencing H2 specifically.

[Copilot]

Pull request overview

Adds Helm chart configurability for the H2 PersistentVolumeClaim (PVC) by introducing new persistence.storageClass and persistence.size values, wiring them into the PVC template, and validating them via the chart’s JSON schema.

Changes:

• Added persistence.storageClass and persistence.size to values.yaml (defaulting size to 256Mi).
• Updated the H2 PVC template to optionally set storageClassName (including "-" → "" behavior) and to source storage size from values.
• Extended values.schema.json to include the new persistence object and require it at the chart root.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
charts/operaton/values.yaml	Introduces persistence values and sets a smaller default size.
charts/operaton/values.schema.json	Adds schema definitions/requirements for persistence.storageClass and persistence.size.
charts/operaton/templates/persistentvolumeclaim.yaml	Uses the new persistence values when rendering the H2 PVC.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

resources.requests.storage is currently rendered only when persistence.size is truthy. A PVC without a storage request is invalid and will be rejected by the Kubernetes API if a user sets persistence.size: "" (or otherwise makes it empty). Prefer always rendering storage (using default/chart default) or failing the render with required when persistence.size is empty, rather than silently omitting it.

Suggested change

	{{- if .Values.persistence.size }}
	storage: {{ .Values.persistence.size }}
	{{- end }}
	storage: {{ required "persistence.size is required and cannot be empty" .Values.persistence.size }}

[Copilot]

These persistence.* values are defined at the chart root, but they only affect the H2 PersistentVolumeClaim (this PVC template is gated by operaton.h2DatabaseIsUsed). Consider clarifying that in the comments so users running an external DB don’t assume these settings have an effect.