[ROCm] Use hermetic llvm with stripped out hipcc wrapper script#41619
Draft
alekstheod wants to merge 11 commits into
Draft
[ROCm] Use hermetic llvm with stripped out hipcc wrapper script#41619alekstheod wants to merge 11 commits into
alekstheod wants to merge 11 commits into
Conversation
alekstheod
force-pushed
the
use_hermetic_clang_for_rocm_config_4
branch
15 times, most recently
from
ae8ad89 to
f347f9f
Compare
alekstheod
force-pushed
the
use_hermetic_clang_for_rocm_config_4
branch
from
f347f9f to
c088825
Compare
alekstheod
force-pushed
the
use_hermetic_clang_for_rocm_config_4
branch
from
316c9f9 to
344e9f0
Compare
alekstheod
force-pushed
the
use_hermetic_clang_for_rocm_config_4
branch
6 times, most recently
from
85d806d to
cad0b94
Compare
alekstheod
force-pushed
the
use_hermetic_clang_for_rocm_config_4
branch
from
30fd95a to
7de076d
Compare
alekstheod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Use hermetic llvm and a custom rocm_library rule for rocm kernels compilation
Remove hipcc_wrapper and dynamic flag resolution, split toolchains
🎯 Justification
Changes utilizing adaptions in this PR: google-ml-infra/rules_ml_toolchain#251
Removing hipcc_wrapper and use a dedicated rule for rocm kernels compilation
🚀 Kind of Contribution
Please remove what does not apply: ♻️ Cleanup
📊 Benchmark (for Performance Improvements)
Not relevant
🧪 Unit Tests:
Not relevant
🧪 Execution Tests:
Not relevant