style: add color to dashboard workflow stats cards#314
Open
Nic13Gamer wants to merge 1 commit intoopenworkflowdev:mainfrom
Open
style: add color to dashboard workflow stats cards#314Nic13Gamer wants to merge 1 commit intoopenworkflowdev:mainfrom
Nic13Gamer wants to merge 1 commit intoopenworkflowdev:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the visual design of workflow statistics cards by adding semantic color coding to differentiate between different workflow states. Each status card now has a subtle colored background and ring border that matches its semantic meaning (e.g., warning for pending, success for completed, destructive for failed).
Changes:
- Added optional
classproperty to workflow stats array with semantic color classes for background and ring borders - Refactored className construction to use the
cnutility instead of template strings - Removed deprecated border classes in favor of ring classes that align with the Card component's defaults
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some color to the background and border of the workflow stat cards. I think it makes it faster/easier to skim through and find the info you need.
Changes
classwith color class-names to stats array in<WorkflowStats />Observations
I also tried adding color to the icons, but found it too much, let me know if you would like it though.
Also removed the
border-color classes from the card. Apparently shadcn/ui now usesring-for the card primitive, I don't know why not useborderthough, to be honest.