Skip to content

Adding corrected generation config for demo#4060

Open
przepeck wants to merge 9 commits intomainfrom
przepeck/unicode_python_fix
Open

Adding corrected generation config for demo#4060
przepeck wants to merge 9 commits intomainfrom
przepeck/unicode_python_fix

Conversation

@przepeck
Copy link
Collaborator

🛠 Summary

CVS-181828
Adding corrected generation config to demo to stop model generation after correct answer.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings March 16, 2026 10:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a generation_config.json file for the VLM NPU demo to ensure the model stops generating after producing the correct answer (by setting proper EOS/pad token IDs). It also updates the demo README with instructions to download this config, and separately unpins dependency versions in the agentic AI demo requirements.

Changes:

  • Added demos/vlm_npu/generation_config.json with EOS/BOS/pad token IDs for Phi-3.5-vision-instruct
  • Updated demos/vlm_npu/README.md with a curl command to download the generation config
  • Removed version pins from openai-agents and openai in demos/continuous_batching/agentic_ai/requirements.txt

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
demos/vlm_npu/generation_config.json New generation config specifying BOS, EOS, and pad token IDs
demos/vlm_npu/README.md Added curl command to download the generation config after model export
demos/continuous_batching/agentic_ai/requirements.txt Removed version pins for openai-agents and openai

You can also share your feedback on Copilot code review. Take the survey.

@przepeck
Copy link
Collaborator Author

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@przepeck przepeck requested review from dtrawins and rasapala March 16, 2026 12:10
@przepeck przepeck force-pushed the przepeck/unicode_python_fix branch from 8e02aac to a7dfc85 Compare March 16, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants