Skip to content

Add standard keyboard scrolling to member list #11809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1-navneet wants to merge 2 commits into from
+97 −0
Closed

Add standard keyboard scrolling to member list #11809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b084c
Add keyboard scrolling support to member list
1-navneet Jan 25, 2026
ca14c05
Fix lint errors in keyboard scrolling handlers
1-navneet Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions css/80_app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2877,6 +2877,13 @@ img.tag-reference-wiki-image {
.section-raw-membership-editor .member-list {
position: relative; /* required for drag-and-drop */
padding-top: 5px;
overflow-y: auto;
max-height: 400px;
}
.section-raw-member-editor .member-list:focus,
.section-raw-membership-editor .member-list:focus {
outline: 2px solid #0066ff;
outline-offset: -2px;
}
.section-raw-member-editor .member-list li,
.section-raw-membership-editor .member-list li {
Expand Down
45 changes: 45 additions & 0 deletions modules/ui/sections/raw_member_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ export function uiSectionRawMemberEditor(context) {
list = list.enter()
.append('ul')
.attr('class', 'member-list')
.attr('tabindex', '0')
.on('mousedown.memberlist', function(event) {
this.focus();
event.stopPropagation();
})
.on('keydown.memberlist', handleListKeydown)
.merge(list);


Expand Down Expand Up @@ -392,6 +398,45 @@ export function uiSectionRawMemberEditor(context) {
}


function handleListKeydown(event) {
event.preventDefault();
event.stopImmediatePropagation();

// Only handle navigation keys when list is focused
if (!['PageDown', 'PageUp', 'End', 'Home', 'ArrowDown', 'ArrowUp'].includes(event.key)) {
return;
}

var listNode = d3_select(this).node();
if (!listNode) return;

var listHeight = listNode.clientHeight;
var scrollTop = listNode.scrollTop;
var scrollHeight = listNode.scrollHeight;

switch (event.key) {
case 'PageDown':
listNode.scrollTop = Math.min(scrollTop + listHeight, scrollHeight - listHeight);
break;
case 'PageUp':
listNode.scrollTop = Math.max(scrollTop - listHeight, 0);
break;
case 'End':
listNode.scrollTop = scrollHeight;
break;
case 'Home':
listNode.scrollTop = 0;
break;
case 'ArrowDown':
listNode.scrollTop = Math.min(scrollTop + 40, scrollHeight - listHeight);
break;
case 'ArrowUp':
listNode.scrollTop = Math.max(scrollTop - 40, 0);
break;
}
}


function unbind() {
var row = d3_select(this);

Expand Down
45 changes: 45 additions & 0 deletions modules/ui/sections/raw_membership_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,12 @@ export function uiSectionRawMembershipEditor(context) {
list = list.enter()
.append('ul')
.attr('class', 'member-list')
.attr('tabindex', '0')
.on('mousedown.memberlist', function(event) {
this.focus();
event.stopPropagation();
})
.on('keydown.memberlist', handleListKeydown)
.merge(list);


Expand Down Expand Up @@ -659,6 +665,45 @@ export function uiSectionRawMembershipEditor(context) {
}


function handleListKeydown(event) {
event.preventDefault();
event.stopImmediatePropagation();

// Only handle navigation keys when list is focused
if (!['PageDown', 'PageUp', 'End', 'Home', 'ArrowDown', 'ArrowUp'].includes(event.key)) {
return;
}

var listNode = d3_select(this).node();
if (!listNode) return;

var listHeight = listNode.clientHeight;
var scrollTop = listNode.scrollTop;
var scrollHeight = listNode.scrollHeight;

switch (event.key) {
case 'PageDown':
listNode.scrollTop = Math.min(scrollTop + listHeight, scrollHeight - listHeight);
break;
case 'PageUp':
listNode.scrollTop = Math.max(scrollTop - listHeight, 0);
break;
case 'End':
listNode.scrollTop = scrollHeight;
break;
case 'Home':
listNode.scrollTop = 0;
break;
case 'ArrowDown':
listNode.scrollTop = Math.min(scrollTop + 40, scrollHeight - listHeight);
break;
case 'ArrowUp':
listNode.scrollTop = Math.max(scrollTop - 40, 0);
break;
}
}


function unbind() {
var row = d3_select(this);

Expand Down
Loading