Remove AdminPassword from mysqldump command line#149
Open
fmount wants to merge 1 commit into
Open
Conversation
The galera pod already has credentials available via /var/local/my.cnf/mysql_pw_cache.cnf (injected by mariadb-operator), which mysql/mysqldump auto-include through the !includedir directive in galera.cnf. Passing -p$dbpass on the command line was redundant and caused the password to appear in the kube-apiserver audit log requestURI (oc exec encodes command args as query parameters). Drop the dbpass parameter from dump_db and the Secret fetch from the main loop, letting the in-pod .cnf handle authentication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
cifmw has https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/os_must_gather/defaults/main.yml#L42 so we should be able to see this effect from the CI job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
galeraPodalready has credentials available via/var/local/my.cnf/mysql_pw_cache.cnf(injected bymariadb-operator), whichmysql/mysqldumpauto-include through the!includedirdirective ingalera.cnf. Passing-p$dbpassin the command line was redundant and caused the password to appear in thekube-apiserveraudit logrequestURI(oc execencodes commandargsas query parameters).This patch drops the
dbpassparameter fromdump_dband theSecretfetch from the main loop, letting the in-pod.cnfhandle authentication.