Fix case-insensitive and YAML-colon matching in PlaintextMask#148
Open
fmount wants to merge 1 commit into
Open
Fix case-insensitive and YAML-colon matching in PlaintextMask#148fmount wants to merge 1 commit into
fmount wants to merge 1 commit into
Conversation
gen_regex only matched `=` as the key-value separator, missing YAML-style `key: value` lines. _applyRegex was also case-sensitive, so keys like `Password` or `PASSWORD` slipped through unmasked. - Broaden gen_regex separator from `=` to `[=:]` - Add re.IGNORECASE flag in _applyRegex - Add regression tests for mixed-case keys and YAML-colon keys Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_regexonly matched=as the key-value separator, missing YAML-stylekey: valuelines._applyRegexwas also case-sensitive.gen_regexseparator from=to[=:]re.IGNORECASEflag in_applyRegex