[WIP] Unify code common 2#1132
Closed
amartyasinha wants to merge 2 commits into
Closed
Conversation
…et names Extract ServiceCommand and config/script secret naming into internal/common/kolla.go and update nova and placement resource builders to use it directly instead of duplicated helpers or pass-through wrappers in internal/nova. Co-authored-by: Cursor <cursoragent@cursor.com>
Move duplicated reconciler, secret, topology, network, and config generation logic into internal/common and refactor nova controllers to embed ReconcilerBase and use the shared helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amartyasinha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This change depends on a change that failed to merge. Change #1130 is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the Depends-On PR is merged, we can rebase this one on top of main. Until now, this PR will also contain both commits to ensure proper testing. (The only reason to break changes into multiple PRs to make things easier for reviewers. But if reviewers prefer to have the entire change in single PR, I can update that).
Depends-On: #1130