Skip to content

[libvirt_manager] Create DNS/DHCP records when mac_map is pre-defined#4032

Draft
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/libvirt-manager-dhcp-with-mac-map
Draft

[libvirt_manager] Create DNS/DHCP records when mac_map is pre-defined#4032
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/libvirt-manager-dhcp-with-mac-map

Conversation

@rebtoor

@rebtoor rebtoor commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

When cifmw_libvirt_manager_mac_map is defined (baremetal deploy-bm flow), generate_networking_data.yml is skipped because MAC addresses are already known. However, this also skips the DNS/DHCP record creation (create_dns_records.yml) which is called at the end of that file.

Without DHCP reservations, compute VMs provisioned by Ironic never get a ctlplane IP, leaving them unreachable for EDPM bootstrap.

Add a separate call to create_dns_records.yml that runs when mac_map is defined and cifmw_networking_env_definition is available.

Related-Issue: ANVIL-109

When cifmw_libvirt_manager_mac_map is defined (baremetal deploy-bm
flow), generate_networking_data.yml is skipped because MAC addresses
are already known. However, this also skips the DNS/DHCP record
creation (create_dns_records.yml) which is called at the end of
that file.

Without DHCP reservations, compute VMs provisioned by Ironic never
get a ctlplane IP, leaving them unreachable for EDPM bootstrap.

Add a separate call to create_dns_records.yml that runs when
mac_map is defined and cifmw_networking_env_definition is available.

Related-Issue: ANVIL-109
Co-authored-by: Cursor <cursoragent@cursor.com>

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4456bfe5270144898c644f89d4a72c77

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 35m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 28s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 38m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 04s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 36s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 49m 38s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 05s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant