[cifmw_cephadm] Add fallback when cifmw_cephadm_rpm_url 404s#4030
Open
fultonj wants to merge 1 commit into
Open
[cifmw_cephadm] Add fallback when cifmw_cephadm_rpm_url 404s#4030fultonj wants to merge 1 commit into
fultonj wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
If `cifmw_cephadm_rpm_url` returns a 404, strip the filename from the URL to get the parent directory, fetch the index page, and search it for a cephadm RPM. If one is found, warn and update `cifmw_cephadm_rpm_url` to the discovered URL. If none is found, fail with a descriptive error. This handles cases where the exact RPM version in the URL has changed (e.g. a compose rebuild with a new NVR) but a valid cephadm package still exists in the same directory. Related-Issue: OSPRH-31757 Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: John Fulton <fulton@redhat.com>
fultonj
force-pushed
the
fallback_cifmw_cephadm_rpm_url
branch
from
f897237 to
f66160b
Compare
fultonj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
cifmw_cephadm_rpm_urlreturns a 404, strip the filename from the URL to get the parent directory, fetch the index page, and search it for a cephadm RPM. If one is found, warn and updatecifmw_cephadm_rpm_urlto the discovered URL. If none is found, fail with a descriptive error.This handles cases where the exact RPM version in the URL has changed (e.g. a compose rebuild with a new NVR) but a valid cephadm package still exists in the same directory.
Related-Issue: OSPRH-31757