[update] Add optional cleanup of OpenStack resources#4023
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
956154a to
f8194fc
Compare
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
f8194fc to
4bc9d77
Compare
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
two small things to consider, largely lgtm
| oc rsh -n {{ cifmw_update_namespace }} openstackclient openstack | ||
|
|
||
| ## User facing | ||
| cifmw_update_dont_cleanup: false |
There was a problem hiding this comment.
maybe a nit and if you disagree and want to keep it this way, that's fine, but I think cifmw_update_cleanup: true would be clearer than the double negative of ...dont_cleanup: false
| ansible.builtin.shell: > | ||
| podman cp lopenstackclient:{{ cifmw_update_artifacts_basedir_suffix }}/. | ||
| {{ cifmw_update_artifacts_basedir }} |
There was a problem hiding this comment.
could be ansible.builtin.comand
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
4bc9d77 to
0c7140f
Compare
The update role creates test workloads (ping test VM, ports) on OpenStack during the update procedure but never cleans them up. This leaves ports allocated on the external network, which blocks subsequent test jobs from recreating subnets. Add a cleanup step at the end of the update role that runs the workload_launch.sh script in cleanup mode to delete the test VM and associated ports. The cleanup runs by default and can be disabled with cifmw_update_dont_cleanup for debugging. Based on the work from openstack-k8s-operators#3335 by Sofer Athlan-Guyot which was closed by the stale bot before merging. Related-Issue: #OSPRH-20307 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
0c7140f to
60b3eb0
Compare
2 participants
The update role creates test workloads (ping test VM, ports) on OpenStack during the update procedure but never cleans them up. This leaves ports allocated on the external network, which blocks subsequent test jobs from recreating subnets.
Add a cleanup step at the end of the update role that runs the workload_launch.sh script in cleanup mode to delete the test VM and associated ports. The cleanup runs by default and can be disabled with cifmw_update_dont_cleanup for debugging.
Based on the work from #3335 by Sofer Athlan-Guyot which was closed by the stale bot before merging.
Related-Issue: #OSPRH-20307