Skip to content

[libvirt_manager] Add opt-in KVM discard/TRIM support#4005

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
michburk:trim-config
Jun 30, 2026
Merged

[libvirt_manager] Add opt-in KVM discard/TRIM support#4005
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
michburk:trim-config

Conversation

@michburk

@michburk michburk commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds fstrim_enabled per-VM-type param. When true, sets discard='unmap' on the primary disk and schedules daily fstrim.timer in the guest via a systemd drop-in over SSH.

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 17, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ad2ec117a00c4e608a2c43340ddb735e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 42m 50s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 06m 55s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 08s
❌ cifmw-molecule-libvirt_manager FAILURE in 20m 49s
✔️ cifmw-molecule-reproducer SUCCESS in 13m 53s

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 23, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/6c3910a5366f4bf583218764fe44fa24

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 29m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 07s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 07m 52s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 45s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 38s
✔️ cifmw-molecule-devscripts SUCCESS in 10m 26s
❌ cifmw-molecule-libvirt_manager FAILURE in 20m 14s
✔️ cifmw-molecule-reproducer SUCCESS in 13m 33s

@michburk michburk force-pushed the trim-config branch 9 times, most recently from 7426d11 to d9f14ea Compare June 25, 2026 18:34
@michburk michburk marked this pull request as ready for review June 25, 2026 20:39
@michburk michburk requested a review from a team June 26, 2026 16:27
Valkyrie00
Valkyrie00 reviewed Jun 26, 2026
View reviewed changes
Comment thread roles/libvirt_manager/tasks/configure_fstrim_vm.yml Outdated
Valkyrie00
Valkyrie00 reviewed Jun 26, 2026
View reviewed changes
Comment thread roles/libvirt_manager/tasks/deploy_layout.yml Outdated
Valkyrie00
Valkyrie00 previously approved these changes Jun 26, 2026
View reviewed changes

@Valkyrie00 Valkyrie00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 26, 2026
evallesp
evallesp previously approved these changes Jun 29, 2026
View reviewed changes

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michburk michburk dismissed stale reviews from evallesp and Valkyrie00 via bd5c101 June 29, 2026 12:59
@openshift-ci openshift-ci Bot removed the lgtm label Jun 29, 2026
@michburk michburk requested review from Valkyrie00 and evallesp June 29, 2026 18:00
@michburk
[libvirt_manager] Add opt-in KVM discard/TRIM support
b8bcc23 
Adds fstrim_enabled per-VM-type param. When true, sets discard='unmap'
on the primary disk and schedules daily fstrim.timer in the guest via
a systemd drop-in over SSH, for all VM types including OCP/RHCOS.

Generated-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Michael Burke <michburk@redhat.com>
evallesp
evallesp reviewed Jun 30, 2026
View reviewed changes

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 30, 2026
Valkyrie00
Valkyrie00 approved these changes Jun 30, 2026
View reviewed changes

@Valkyrie00 Valkyrie00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nemarjan

nemarjan commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nemarjan, Valkyrie00

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Valkyrie00,nemarjan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d12f660 into openstack-k8s-operators:main Jun 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp left review comments
@Valkyrie00 Valkyrie00 Valkyrie00 approved these changes

Assignees

@Valkyrie00 Valkyrie00

@evallesp evallesp

@nemarjan nemarjan

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michburk @nemarjan @Valkyrie00 @evallesp