Change Github Action permissions#3465
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
improve-verify-gh-action
branch
6 times, most recently
from
f5031e1 to
0fed78b
Compare
danpawlik
changed the title
danpawlik
force-pushed
the
improve-verify-gh-action
branch
7 times, most recently
from
d3a2dbc to
605e130
Compare
danpawlik
force-pushed
the
improve-verify-gh-action
branch
from
605e130 to
48d9e7b
Compare
Currently the commit-message-validator.yml Github Action raise an issue
when the commit message is improper:
Resource not accessible by integration
Let's try if this would help.
Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
improve-verify-gh-action
branch
from
48d9e7b to
6c08a1a
Compare
There was a problem hiding this comment.
Tested in my own fork: michburk#2
The commit body workflow seems to trigger twice on each event (make sure to check the collapsed "1 similar comment" sections in the above pr), and there are extra 'my comment' comments.
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.issue.number, | ||
| body: 'my comment' |
There was a problem hiding this comment.
This adds an additional my comment comment from the bot on the pr
| on: | ||
| pull_request_target: | ||
| types: [opened, synchronize, edited, reopened] | ||
| pull_request: |
There was a problem hiding this comment.
I think running on both pull_request_target AND pull_request [open/sync/edit/reopen] means the workflow will run twice for each event, leaving two comments instead of one. Maybe we could just trigger on pull_request_target?
There was a problem hiding this comment.
I tried, nothing helped.
|
This PR is stale because it has been for over 15 days with no activity. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Currently the commit-message-validator.yml Github Action raise an issue
when the commit message is improper:
Let's try if this would help.