Skip to content

OCPBUGS-79992,OCPBUGS-79991,OCPBUGS-79988: Replace google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.67.3-sec.1 to avoid go version bump and fix CVE-2026-33186#1201

Open
kunalmemane wants to merge 2 commits into
openshift:release-4.16from
kunalmemane:CVE-2026-33186-4.16
Open

OCPBUGS-79992,OCPBUGS-79991,OCPBUGS-79988: Replace google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.67.3-sec.1 to avoid go version bump and fix CVE-2026-33186#1201
kunalmemane wants to merge 2 commits into
openshift:release-4.16from
kunalmemane:CVE-2026-33186-4.16

Conversation

@kunalmemane
Copy link
Copy Markdown
Member

The sriov-network-operator on the release-4.16 branch currently utilizes Go 1.21. Upgrading google.golang.org/grpc to v1.79.3 would force bump to Go 1.24.

To resolve CVE-2026-33186 while maintaining Go 1.21 compatibility, replace the standard gRPC dependency with github.com/openshift-sustaining/grpc-go at version v1.67.3-sec.1, which includes the necessary security patch.

…rpc-go v1.67.3-sec.1 to avoid go version bump and fix CVE-2026-33186

Signed-off-by: Kunal Memane <kmemane@redhat.com>
….3-sec.1

Signed-off-by: Kunal Memane <kmemane@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@kunalmemane: This pull request references Jira Issue OCPBUGS-79992, which is invalid:

  • expected Jira Issue OCPBUGS-79992 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-79991, which is invalid:

  • expected Jira Issue OCPBUGS-79991 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-79988, which is invalid:

  • expected Jira Issue OCPBUGS-79988 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The sriov-network-operator on the release-4.16 branch currently utilizes Go 1.21. Upgrading google.golang.org/grpc to v1.79.3 would force bump to Go 1.24.

To resolve CVE-2026-33186 while maintaining Go 1.21 compatibility, replace the standard gRPC dependency with github.com/openshift-sustaining/grpc-go at version v1.67.3-sec.1, which includes the necessary security patch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from Billy99 and MrSanketkumar April 22, 2026 12:19
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunalmemane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2026
@kunalmemane
Copy link
Copy Markdown
Member Author

/test controllers

1 similar comment
@kunalmemane
Copy link
Copy Markdown
Member Author

/test controllers

@kunalmemane kunalmemane force-pushed the CVE-2026-33186-4.16 branch from 87b117e to a84ece8 Compare May 4, 2026 17:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

@kunalmemane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/controllers a84ece8 link true /test controllers

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants