OCM-21663 | feat: Allow min-replicas=0 for HCP nodepool autoscaling#3175
Open
jhjaggars wants to merge 2 commits intoopenshift:masterfrom
Open
OCM-21663 | feat: Allow min-replicas=0 for HCP nodepool autoscaling#3175jhjaggars wants to merge 2 commits intoopenshift:masterfrom
jhjaggars wants to merge 2 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhjaggars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jhjaggars
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Updated CLI validation to allow minimum of 0 replicas for HCP nodepool autoscaling, matching the relaxed API constraints for customers with that capability enabled. Changes: - Updated validation in pkg/machinepool/machinepool.go to allow min >= 0 - Updated interactive validator in pkg/machinepool/helper.go for HCP - Updated unit tests to verify min=0 succeeds and negative values fail - Added comprehensive HCP-specific test coverage in helper_test.go - Updated E2E tests to expect min=0 to succeed The changes align HCP nodepool validation with Classic machinepool behavior while maintaining all other safety constraints (negative values still rejected, multi-AZ multiples of 3 still enforced). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jhjaggars
force-pushed
the
allow-min-zero-replicas-hcp-nodepool
branch
from
cd3e4e0 to
5dee9f4
Compare
Fix undefined variable error in HCP machine pool test by properly declaring expectErrMsg variable. Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated CLI validation to allow minimum of 0 replicas for HCP nodepool autoscaling, matching the relaxed API constraints for customers with that capability enabled.
Changes:
The changes align HCP nodepool validation with Classic machinepool behavior while maintaining all other safety constraints (negative values still rejected, multi-AZ multiples of 3 still enforced).
🤖 Generated with Claude Code